Conversation
|
hi @TrafalgarSX , thanks for your contribution, this change looks good, but I have some concerns. 1.You didn't implement all methods in Please look into this definition of There are 4 methods in this interface, you have implemented 2 (actually 1 because you just return false in 'CefJSDialogHandler::OnBeforeUnloadDialog'). I think this is not correct implementation, at least this is not complement implementation. The following methods are designed to be called by the CEF initiated from inner context or JavaScript context. you only implemented 'OnJSDialog', looks pretty cool and it will display dialog with your implementation, but what will happen if CEF calls 2.CefJSDialogHandler currently is only useful for linux, so I think we'd better keep the default implementation for other platforms. please refer to the CEF test implementation: |
eaa882c to
4919e35
Compare
955d0ef to
11e59e2
Compare
17d9e36 to
07b1c11
Compare
CefView/QCefView#191